<html>
<head><meta charset="utf-8"><title>rustc test suite triage · wg-traits · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/index.html">wg-traits</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html">rustc test suite triage</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="212178691"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212178691" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Nathan Whitaker <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212178691">(Oct 03 2020 at 16:16)</a>:</h4>
<p>Hey all, I've been working a bit on starting to categorize the test failures in rustc. Just some broad impressions right now (incomplete, obtained using a  hacky python script), I'll just leave them here:</p>
<div class="codehilite"><pre><span></span><code>3930 Failures Accounted For
------------------
2510 Unimplemented Panics
---------
rustc_traits/src/chalk/lowering.rs:523 -&gt; 1929  (Static Lifetime)
rustc_traits/src/chalk/lowering.rs:704 -&gt; 225 (Lower ExistentialPredicate::Projection)
rustc_traits/src/chalk/lowering.rs:287 -&gt; 198 (Req. Const eval)
rustc_traits/src/chalk/mod.rs:73 -&gt; 61 (Lower CanonicalVarKind::PlaceholderTy)
rustc_traits/src/chalk/lowering.rs:363 -&gt; 29 (Lower Generators)
rustc_traits/src/chalk/lowering.rs:430 -&gt; 22 (Lower into chalk_ir::TypeName::Array [const eval?])
rustc_traits/src/chalk/lowering.rs:569 -&gt; 16 (Req. Const eval)
rustc_traits/src/chalk/lowering.rs:487 -&gt; 10  (Lower into chalk_ir::TyData::Function)
chalk-solve-0.28.0/src/clauses.rs:60 -&gt; 7 (Constituent types for TypeName::AssociatedType)
chalk-solve-0.28.0/src/clauses.rs:59 -&gt; 5 (Constituent types for TypeName::OpaqueType)
rustc_traits/src/chalk/lowering.rs:486 -&gt; 5 (Lower into chalk_ir::TyData::Alias)
rustc_traits/src/chalk/lowering.rs:518 -&gt; 1 (Lower ty::BoundRegion::BrNamed)
rustc_traits/src/chalk/lowering.rs:521 -&gt; 1 (Lower RegionKind::ReFree)
rustc_traits/src/chalk/lowering.rs:534 -&gt; 1 (Lower RegionKind::ReErased)

518 Index OOB Panics
---------
chalk-ir-0.28.0/src/fold/subst.rs:62 -&gt; 444 (fold_free_var_ty)
rustc_traits/src/chalk/db.rs:528 -&gt; 51 (closure_outputs_and_inputs)
chalk-ir-0.28.0/src/fold/subst.rs:82 -&gt; 17 (fold_free_var_lifetime)
rustc_infer/src/infer/canonical/substitute.rs:80 -&gt; 6 (substitute_value)

453 Assoc. Type Norm. Failures
---------

403 Inference Failures
---------

46 &quot;Skipped Bound Var&quot; Failures
---------
</code></pre></div>



<a name="212179817"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212179817" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212179817">(Oct 03 2020 at 16:49)</a>:</h4>
<p><span class="user-mention silent" data-user-id="230601">Nathan Whitaker</span> <a href="#narrow/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage/near/212178691">said</a>:</p>
<blockquote>
<p>Hey all, I've been working a bit on starting to categorize the test failures in rustc. Just some broad impressions right now (incomplete, obtained using a  hacky python script), I'll just leave them here:</p>
</blockquote>
<p>This is fantastic</p>



<a name="212179822"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212179822" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212179822">(Oct 03 2020 at 16:49)</a>:</h4>
<p>Seems like <code>'static</code> is a huge bit of problems</p>



<a name="212179871"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212179871" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212179871">(Oct 03 2020 at 16:50)</a>:</h4>
<p>Those Index OOB Panics  are a bit suspicious</p>



<a name="212180581"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212180581" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212180581">(Oct 03 2020 at 17:09)</a>:</h4>
<p>I'm gonna implement <code>'static</code> real quick</p>



<a name="212180584"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212180584" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212180584">(Oct 03 2020 at 17:10)</a>:</h4>
<p>Anybody gonna be around today to review and merge?</p>



<a name="212180626"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212180626" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212180626">(Oct 03 2020 at 17:10)</a>:</h4>
<p>And get it in the release tonight</p>



<a name="212180629"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212180629" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212180629">(Oct 03 2020 at 17:10)</a>:</h4>
<p>I've got a branch with a start on <code>'static</code> somewhere</p>



<a name="212180635"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212180635" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212180635">(Oct 03 2020 at 17:11)</a>:</h4>
<p><a href="https://github.com/rust-lang/chalk/compare/master...detrumi:static-lifetimes">https://github.com/rust-lang/chalk/compare/master...detrumi:static-lifetimes</a></p>



<a name="212180638"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212180638" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212180638">(Oct 03 2020 at 17:11)</a>:</h4>
<p>Got a few todo's in it, but the basic infra is therer</p>



<a name="212180652"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212180652" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212180652">(Oct 03 2020 at 17:12)</a>:</h4>
<p>So <span class="user-mention" data-user-id="232957">@Jack Huey</span> feel free to continue from there <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span></p>



<a name="212180690"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212180690" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212180690">(Oct 03 2020 at 17:12)</a>:</h4>
<p>I basically copied from Niko's branch</p>



<a name="212180694"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212180694" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212180694">(Oct 03 2020 at 17:12)</a>:</h4>
<p>but I'll look through yours too</p>



<a name="212184543"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212184543" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthew Jasper <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212184543">(Oct 03 2020 at 18:41)</a>:</h4>
<p><span class="user-mention silent" data-user-id="232957">Jack Huey</span> <a href="#narrow/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage/near/212180584">said</a>:</p>
<blockquote>
<p>Anybody gonna be around today to review and merge?</p>
</blockquote>
<p>I can review this</p>



<a name="212185145"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212185145" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212185145">(Oct 03 2020 at 18:56)</a>:</h4>
<p><a href="https://github.com/rust-lang/chalk/pull/617">https://github.com/rust-lang/chalk/pull/617</a></p>



<a name="212185676"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212185676" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthew Jasper <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212185676">(Oct 03 2020 at 19:11)</a>:</h4>
<p>I think <a href="https://github.com/rust-lang/rust/issues/73905">#73905</a> helps more tests pass with Chalk as well.</p>



<a name="212186780"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212186780" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212186780">(Oct 03 2020 at 19:41)</a>:</h4>
<p>Is there a reason to use <code>forall&lt;'s&gt; { .. }</code> instead of <code>'static</code> directly?</p>



<a name="212187810"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212187810" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212187810">(Oct 03 2020 at 20:09)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116118">Matthew Jasper</span> <a href="#narrow/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage/near/212185676">said</a>:</p>
<blockquote>
<p>I think <a href="https://github.com/rust-lang/rust/issues/73905">#73905</a> helps more tests pass with Chalk as well.</p>
</blockquote>
<p>It might! Definitely anything related to GATs</p>



<a name="212187862"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212187862" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212187862">(Oct 03 2020 at 20:10)</a>:</h4>
<p><span class="user-mention silent" data-user-id="125131">detrumi</span> <a href="#narrow/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage/near/212186780">said</a>:</p>
<blockquote>
<p>Is there a reason to use <code>forall&lt;'s&gt; { .. }</code> instead of <code>'static</code> directly?</p>
</blockquote>
<p>They're logically a bit different. But you could imagine we might unify them one day</p>



<a name="212192673"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212192673" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212192673">(Oct 03 2020 at 22:24)</a>:</h4>
<p>Using the latest master with statics: 5058 passed; 5694 failed; 93 ignored;</p>



<a name="212192677"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212192677" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212192677">(Oct 03 2020 at 22:24)</a>:</h4>
<p>(I also added <code>ignore-compare-mode-chalk</code> to the tests that never finished)</p>



<a name="212195473"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212195473" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212195473">(Oct 03 2020 at 23:40)</a>:</h4>
<p>Also,  properly implemented lowering from chalk arrays,  and existential predicates and this is what we're at looking only at "not implemented"s</p>
<div class="codehilite"><pre><span></span><code>     45 thread &#39;rustc&#39; panicked at &#39;not implemented&#39;, compiler/rustc_traits/src/chalk/lowering.rs:363:47
      7 thread &#39;rustc&#39; panicked at &#39;not implemented&#39;, compiler/rustc_traits/src/chalk/lowering.rs:493:41
     12 thread &#39;rustc&#39; panicked at &#39;not implemented&#39;, compiler/rustc_traits/src/chalk/lowering.rs:494:49
      4 thread &#39;rustc&#39; panicked at &#39;not implemented&#39;, compiler/rustc_traits/src/chalk/lowering.rs:525:61
      1 thread &#39;rustc&#39; panicked at &#39;not implemented&#39;, compiler/rustc_traits/src/chalk/lowering.rs:528:26
      1 thread &#39;rustc&#39; panicked at &#39;not implemented&#39;, compiler/rustc_traits/src/chalk/lowering.rs:540:25
     75 thread &#39;rustc&#39; panicked at &#39;not implemented&#39;, compiler/rustc_traits/src/chalk/mod.rs:69:61
     14 thread &#39;rustc&#39; panicked at &#39;not implemented&#39;, compiler/rustc_traits/src/chalk/mod.rs:89:53
      7 thread &#39;rustc&#39; panicked at &#39;not implemented&#39;, /home/hueyj/.cargo/git/checkouts/chalk-af2ed8365b2aac89/a1dc34d/chalk-solve/src/clauses.rs:80:36
     10 thread &#39;rustc&#39; panicked at &#39;not implemented&#39;, /home/hueyj/.cargo/git/checkouts/chalk-af2ed8365b2aac89/a1dc34d/chalk-solve/src/clauses.rs:81:40
</code></pre></div>



<a name="212195479"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212195479" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212195479">(Oct 03 2020 at 23:41)</a>:</h4>
<p>Last two are auto trait related</p>



<a name="212195495"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212195495" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212195495">(Oct 03 2020 at 23:41)</a>:</h4>
<p>chalk/mod ones are <code>PlaceholderTy</code> and <code>Const</code> <code>CanonicalVarKind</code></p>



<a name="212195541"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212195541" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212195541">(Oct 03 2020 at 23:42)</a>:</h4>
<p>363 is <code>Generator</code> lowering (cc <span class="user-mention" data-user-id="125294">@Aaron Hill</span> could you take a look how to lower generators; the representation is a bit different in chalk than rustc)</p>



<a name="212195550"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212195550" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212195550">(Oct 03 2020 at 23:43)</a>:</h4>
<p>493 and 494 are lowering from chalk Alias and Function</p>



<a name="212195561"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212195561" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212195561">(Oct 03 2020 at 23:43)</a>:</h4>
<p>525 is <code>BrNamed</code> lowering, which should have been caught elsewhere and converted to <code>BrAnon</code></p>



<a name="212195564"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212195564" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212195564">(Oct 03 2020 at 23:44)</a>:</h4>
<p>528 is <code>ReFree</code> lowering</p>



<a name="212195606"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212195606" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212195606">(Oct 03 2020 at 23:44)</a>:</h4>
<p>540 is <code>ReErased</code>, which also should have been caught elsewhere</p>



<a name="212195626"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212195626" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212195626">(Oct 03 2020 at 23:45)</a>:</h4>
<p>There are a bunch of <code>Const not implemented</code> panics</p>



<a name="212195836"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212195836" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212195836">(Oct 03 2020 at 23:51)</a>:</h4>
<p>Still nearly 2000</p>
<div class="codehilite"><pre><span></span><code>thread &#39;rustc&#39; panicked at &#39;assertion failed: `(left == right)`
  left: `^1`,
 right: `^0`&#39;
</code></pre></div>



<a name="212195897"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212195897" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212195897">(Oct 03 2020 at 23:53)</a>:</h4>
<p>Oh, these numbers are probably not right since x.py test skips bytes if there are too many</p>



<a name="212197720"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212197720" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212197720">(Oct 04 2020 at 00:38)</a>:</h4>
<p>All the ICEs: <a href="https://pastebin.com/6GXS2n5R">https://pastebin.com/6GXS2n5R</a></p>



<a name="212197731"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212197731" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212197731">(Oct 04 2020 at 00:38)</a>:</h4>
<p>All the "rustc panicked at": <a href="https://pastebin.com/wCHasDnp">https://pastebin.com/wCHasDnp</a></p>



<a name="212197816"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212197816" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212197816">(Oct 04 2020 at 00:41)</a>:</h4>
<p>The full log of all the tests: <a href="https://www.dropbox.com/s/5itvgbuacpjdbje/log.txt?dl=0">https://www.dropbox.com/s/5itvgbuacpjdbje/log.txt?dl=0</a></p>
<div class="message_inline_ref"><a href="https://www.dropbox.com/s/5itvgbuacpjdbje/log.txt?dl=0" title="log.txt"><img src="https://www.dropbox.com/static/images/spectrum-icons/generated/content/content-txt-large.png"></a><div><div class="message_inline_image_title">log.txt</div><desc class="message_inline_image_desc"></desc></div></div>



<a name="212197832"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212197832" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212197832">(Oct 04 2020 at 00:41)</a>:</h4>
<p>Line numbers won't be exactly correct</p>



<a name="212208477"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212208477" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212208477">(Oct 04 2020 at 06:16)</a>:</h4>
<p>5235 passed; 5516 failed; 94 ignored with the fix <a href="https://github.com/rust-lang/chalk/issues/556">here</a></p>



<a name="212220341"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212220341" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212220341">(Oct 04 2020 at 12:07)</a>:</h4>
<p><span class="user-mention" data-user-id="232957">@Jack Huey</span> once <a href="https://github.com/rust-lang/rust/pull/77515">https://github.com/rust-lang/rust/pull/77515</a> gets merged, I'll take a look at implementing generator lowering</p>



<a name="212477086"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212477086" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Nathan Whitaker <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212477086">(Oct 06 2020 at 19:58)</a>:</h4>
<p>Found a nice and simple reproducer for the assertion failure panics:</p>
<div class="codehilite" data-code-language="Rust"><pre><span></span><code><span class="k">fn</span> <span class="nf">main</span><span class="p">()</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
<span class="w">    </span><span class="n">println</span><span class="o">!</span><span class="p">(</span><span class="s">"Hello {}!"</span><span class="p">,</span><span class="w"> </span><span class="s">"world"</span><span class="p">);</span><span class="w"></span>
<span class="p">}</span><span class="w"></span>
</code></pre></div>



<a name="212477174"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212477174" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212477174">(Oct 06 2020 at 19:59)</a>:</h4>
<p>Oh, yeah. It's the variance :)</p>



<a name="212477194"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212477194" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212477194">(Oct 06 2020 at 19:59)</a>:</h4>
<p>Well, no</p>



<a name="212477225"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212477225" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212477225">(Oct 06 2020 at 19:59)</a>:</h4>
<p>This: <a href="https://github.com/rust-lang/chalk/issues/556">https://github.com/rust-lang/chalk/issues/556</a></p>



<a name="212477233"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/212477233" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#212477233">(Oct 06 2020 at 19:59)</a>:</h4>
<p>And then variance</p>



<a name="221363628"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/221363628" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#221363628">(Jan 01 2021 at 18:51)</a>:</h4>
<p>Just made a PR (<a href="https://github.com/rust-lang/rust/issues/80593">#80593</a>) to upgrade chalk. Currently blocked on <a href="https://github.com/rust-lang/chalk/issues/670">chalk#670</a>, but I also have a PR open on Chalk to fix that. In them meantime, I'm reupdating some test suite triage with compare-mode=chalk</p>



<a name="221363683"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/221363683" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#221363683">(Jan 01 2021 at 18:52)</a>:</h4>
<p>For SLG:<br>
test result: FAILED. 6280 passed; 4812 failed; 103 ignored; 0 measured; 0 filtered out; finished in 395.46s</p>



<a name="221363719"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/221363719" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#221363719">(Jan 01 2021 at 18:53)</a>:</h4>
<p>And a pastebin of panics: <a href="https://pastebin.com/rj10X7NR">https://pastebin.com/rj10X7NR</a></p>



<a name="221363792"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/221363792" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#221363792">(Jan 01 2021 at 18:54)</a>:</h4>
<p>The good news is <em>most</em> of the remaining failures aren't because of panics but problems solving</p>



<a name="221364457"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/rustc%20test%20suite%20triage/near/221364457" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/rustc.20test.20suite.20triage.html#221364457">(Jan 01 2021 at 19:11)</a>:</h4>
<p>Unfortunately, it looks like substituting in the recursive solver makes some tests never finish</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>